From ebe3e6440ce49e51c41620161961c4b39c373276 Mon Sep 17 00:00:00 2001 From: Tim Deegan Date: Wed, 9 Feb 2011 12:03:09 +0000 Subject: [PATCH] x86/mm/shadow: fix unlocking on error path in p2m allocator One unlock path wasn't gated to match the lock. Signed-off-by: Tim Deegan --- xen/arch/x86/mm/shadow/common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index 65a2b03e4f..dd9a1555ae 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1634,7 +1634,8 @@ shadow_alloc_p2m_page(struct domain *d) if ( d->arch.paging.shadow.total_pages < shadow_min_acceptable_pages(d) + 1 ) { - shadow_unlock(d); + if ( do_locking ) + shadow_unlock(d); return NULL; } -- 2.30.2